From 167a2116f17f4c4e854dde0d729b4cbd18c7b4ce Mon Sep 17 00:00:00 2001
From: Thor77 <thor77@thor77.org>
Date: Fri, 14 Jun 2019 16:47:31 +0200
Subject: [PATCH] Prevent duplicate bets on the same match

---
 app/services/user_service.rb       |  1 +
 spec/services/user_service_spec.rb | 25 ++++++++++++++++++++-----
 2 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/app/services/user_service.rb b/app/services/user_service.rb
index 37f181f..0050189 100644
--- a/app/services/user_service.rb
+++ b/app/services/user_service.rb
@@ -18,5 +18,6 @@ class UserService
     else
       raise UserServiceError, 'The given team is not involved in the given match' unless match.teams.include? team
     end
+    raise UserServiceError, 'This user already created a bet on this match' if match.bets.map(&:user).include? @user
   end
 end
diff --git a/spec/services/user_service_spec.rb b/spec/services/user_service_spec.rb
index f0150f2..b949d07 100644
--- a/spec/services/user_service_spec.rb
+++ b/spec/services/user_service_spec.rb
@@ -21,20 +21,34 @@ RSpec.describe UserService do
         create(:playoff_match, match_scores: [create(:match_score, team: @team)])
       end
 
-      let(:bet) do
-        @service.bet! match, @team
+      before do
+        @bet = @service.bet! match, @team
+        @user.reload
+        match.reload
+        @team.reload
       end
 
       it 'associates the bet with the given team' do
-        expect(@team.bets).to include(bet)
+        expect(@team.bets).to include(@bet)
       end
 
       it 'associates the bet with the given match' do
-        expect(match.bets).to include(bet)
+        expect(match.bets).to include(@bet)
       end
 
       it 'associates the bet with the creating user' do
-        expect(@user.bets).to include(bet)
+        expect(@user.bets).to include(@bet)
+      end
+
+      context 'with an already existing bet' do
+        it 'throws an exception' do
+          match = create(:playoff_match, match_scores: [create(:match_score, team: @team)])
+          @service.bet! match, @team
+          match.reload
+          expect do
+            @service.bet! match, @team
+          end.to raise_error(UserServiceError, 'This user already created a bet on this match')
+        end
       end
     end
 
@@ -54,6 +68,7 @@ RSpec.describe UserService do
           match = create(:group_match)
           match.match_scores << create(:match_score, team: @team)
           bet = @service.bet! match, nil
+          match.reload
           expect(match.bets).to include(bet)
           expect(@user.bets).to include(bet)
         end