From 16e65a3b0344eca945ced506130fc903b0e82190 Mon Sep 17 00:00:00 2001 From: Malaber Date: Mon, 10 Mar 2025 12:56:20 +0100 Subject: [PATCH] Fix missing checks --- app/controllers/tournaments_controller.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/controllers/tournaments_controller.rb b/app/controllers/tournaments_controller.rb index 6cab8e9..2e33843 100644 --- a/app/controllers/tournaments_controller.rb +++ b/app/controllers/tournaments_controller.rb @@ -190,11 +190,15 @@ def validate_set_timer_end_params if timer_end_seconds.present? begin - parsed_time = Time.zone.now + timer_end_seconds.to_i - params[:timer_end] = parsed_time + timer_end_seconds = Integer(timer_end_seconds) rescue ArgumentError return render json: { error: 'Invalid seconds format' }, status: :unprocessable_entity end + + return render json: { error: 'Timer end must be in the future' }, status: :unprocessable_entity if timer_end_seconds <= 0 + + parsed_time = Time.zone.now + timer_end_seconds + params[:timer_end] = parsed_time elsif timer_end.present? begin parsed_time = Time.zone.parse(timer_end)