From 3fc8132538e779c769b956f6b0e77263c5aedcb3 Mon Sep 17 00:00:00 2001 From: Malaber <32635600+Malaber@users.noreply.github.com> Date: Wed, 24 Apr 2019 22:32:05 +0200 Subject: [PATCH] Return false if no groups are given to generate_group_stage method This prevents dividing by zero in the next line --- app/services/group_stage_service.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/services/group_stage_service.rb b/app/services/group_stage_service.rb index 7a8df7a..f7ab289 100644 --- a/app/services/group_stage_service.rb +++ b/app/services/group_stage_service.rb @@ -2,6 +2,7 @@ class GroupStageService def self.generate_group_stage(groups) + return false if groups.length.zero? average_group_size = (groups.map{ |g| g.teams }.flatten.length.to_f / groups.length.to_f) if (average_group_size %1).zero? groups = groups.map { |group| get_group_object_from(group) }