From 667d6a028ca58f4ea5038d995fd8957ffa10911d Mon Sep 17 00:00:00 2001 From: Thor77 Date: Sun, 7 Apr 2019 13:40:03 +0200 Subject: [PATCH] Test controller params as they're documented --- spec/controllers/match_scores_controller_spec.rb | 6 +++--- spec/controllers/teams_controller_spec.rb | 6 +++--- spec/controllers/tournaments_controller_spec.rb | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/spec/controllers/match_scores_controller_spec.rb b/spec/controllers/match_scores_controller_spec.rb index f2429ce..67f9b1a 100644 --- a/spec/controllers/match_scores_controller_spec.rb +++ b/spec/controllers/match_scores_controller_spec.rb @@ -36,13 +36,13 @@ RSpec.describe MatchScoresController, type: :controller do end it 'updates the requested score' do - put :update, params: { id: @match_score.to_param, match_score: valid_update } + put :update, params: { id: @match_score.to_param }.merge(valid_update) @match_score.reload expect(@match_score.points).to eq(valid_update[:points]) end it 'renders a response with the updated team' do - put :update, params: { id: @match_score.to_param, match_score: valid_update } + put :update, params: { id: @match_score.to_param }.merge(valid_update) expect(response).to be_successful body = deserialize_response response expect(body[:points]).to eq(valid_update[:points]) @@ -55,7 +55,7 @@ RSpec.describe MatchScoresController, type: :controller do end it 'renders a forbidden error response' do - put :update, params: { id: @match_score.to_param, match_score: valid_update } + put :update, params: { id: @match_score.to_param }.merge(valid_update) expect(response).to have_http_status(:forbidden) end end diff --git a/spec/controllers/teams_controller_spec.rb b/spec/controllers/teams_controller_spec.rb index 1eaaec7..7bcbdb8 100644 --- a/spec/controllers/teams_controller_spec.rb +++ b/spec/controllers/teams_controller_spec.rb @@ -34,14 +34,14 @@ RSpec.describe TeamsController, type: :controller do end it 'updates the requested team' do - put :update, params: { id: @team.to_param, team: valid_update } + put :update, params: { id: @team.to_param }.merge(valid_update) @team.reload expect(response).to be_successful expect(@team.name).to eq(valid_update[:name]) end it 'renders a response with the updated team' do - put :update, params: { id: @team.to_param, team: valid_update } + put :update, params: { id: @team.to_param }.merge(valid_update) expect(response).to be_successful body = deserialize_response response expect(body[:name]).to eq(valid_update[:name]) @@ -54,7 +54,7 @@ RSpec.describe TeamsController, type: :controller do end it 'renders a forbidden error response' do - put :update, params: { id: @team.to_param, team: valid_update } + put :update, params: { id: @team.to_param }.merge(valid_update) expect(response).to have_http_status(:forbidden) end end diff --git a/spec/controllers/tournaments_controller_spec.rb b/spec/controllers/tournaments_controller_spec.rb index 8558a35..468054b 100644 --- a/spec/controllers/tournaments_controller_spec.rb +++ b/spec/controllers/tournaments_controller_spec.rb @@ -116,7 +116,7 @@ RSpec.describe TournamentsController, type: :controller do context 'with valid params' do context 'without authentication headers' do it 'renders a unauthorized error response' do - put :update, params: { id: @tournament.to_param, tournament: valid_update } + put :update, params: { id: @tournament.to_param }.merge(valid_update) expect(response).to have_http_status(:unauthorized) end end @@ -127,13 +127,13 @@ RSpec.describe TournamentsController, type: :controller do end it 'updates the requested tournament' do - put :update, params: { id: @tournament.to_param, tournament: valid_update } + put :update, params: { id: @tournament.to_param }.merge(valid_update) @tournament.reload expect(@tournament.name).to eq(valid_update[:name]) end it 'renders a JSON response with the tournament' do - put :update, params: { id: @tournament.to_param, tournament: valid_update } + put :update, params: { id: @tournament.to_param }.merge(valid_update) expect(response).to have_http_status(:ok) expect(response.content_type).to eq('application/json') end @@ -145,7 +145,7 @@ RSpec.describe TournamentsController, type: :controller do end it 'renders a forbidden error response' do - put :update, params: { id: @tournament.to_param, tournament: valid_update } + put :update, params: { id: @tournament.to_param }.merge(valid_update) expect(response).to have_http_status(:forbidden) end end