diff --git a/spec/controllers/tournaments_controller_spec.rb b/spec/controllers/tournaments_controller_spec.rb index 02c8277..330ed5a 100644 --- a/spec/controllers/tournaments_controller_spec.rb +++ b/spec/controllers/tournaments_controller_spec.rb @@ -172,19 +172,19 @@ RSpec.describe TournamentsController, type: :controller do expect(included_teams).to match_array(@teams) end - context 'generates a group stage tournament' do + context 'with parameter group_stage=true' do before(:each) do post :create, params: create_group_tournament_data body = deserialize_response response @group_stage_tournament = Tournament.find(body[:id]) end - it 'with all given teams in their respective groups' do + it 'generates a group stage with all teams given in parameters' do included_teams = @group_stage_tournament.stages.find_by(level: -1).teams expect(included_teams).to match_array(@teams16) end - it 'which is a stage' do + it 'generates a group stage' do group_stage = @group_stage_tournament.stages.find_by(level: -1) expect(group_stage).to be_a(Stage) end diff --git a/spec/interactors/add_group_stage_to_tournament_interactor_spec.rb b/spec/interactors/add_group_stage_to_tournament_interactor_spec.rb index ca126dc..1c14d49 100644 --- a/spec/interactors/add_group_stage_to_tournament_interactor_spec.rb +++ b/spec/interactors/add_group_stage_to_tournament_interactor_spec.rb @@ -23,8 +23,8 @@ RSpec.describe AddGroupStageToTournament do .and_return(@group_stage) end - context 'Empty tournament' do - it 'context succeeds' do + context 'empty tournament' do + it 'succeeds' do expect(empty_tournament_context).to be_a_success end @@ -42,12 +42,12 @@ RSpec.describe AddGroupStageToTournament do .and_return(false) end - it 'context fails' do + it 'fails' do expect(empty_tournament_context).to be_a_failure end end - context 'Tournament where group stage is already generated' do + context 'tournament where group stage is already generated' do it 'does not add group stage' do expect(group_stage_tournament_context).to be_a_failure end diff --git a/spec/services/group_stage_service_spec.rb b/spec/services/group_stage_service_spec.rb index 1d18b63..a6b97c4 100644 --- a/spec/services/group_stage_service_spec.rb +++ b/spec/services/group_stage_service_spec.rb @@ -7,7 +7,7 @@ RSpec.describe GroupStageService do @teams2 = create_list(:team, 4) @groups = Hash[1 => @teams1, 2 => @teams2].values end - describe 'generate_group_stage method' do + describe '#generate_group_stage method' do it 'returns a stage object' do group_stage = GroupStageService.generate_group_stage(@groups) expect(group_stage).to be_a(Stage) @@ -31,14 +31,14 @@ RSpec.describe GroupStageService do end end - describe 'get_group_object_from' do + describe '#get_group_object_from' do it 'returns a group' do group = GroupStageService.get_group_object_from(@teams1) expect(group).to be_a(Group) end end - describe 'generate_all_matches_between' do + describe '#generate_all_matches_between' do it 'generates a list of not started matches' do matches = GroupStageService.generate_all_matches_between(@teams2) matches.each do |match|