Rename create_data to create_playoff_tournament_data

This is done in preparation for the addition of group stage data
within the next few commits
This commit is contained in:
Daniel Schädler 2019-04-24 12:33:17 +02:00
parent 240a6d6ca6
commit c9093dca0b
1 changed files with 10 additions and 10 deletions

View File

@ -103,7 +103,7 @@ RSpec.describe TournamentsController, type: :controller do
end end
describe 'POST #create' do describe 'POST #create' do
let(:create_data) do let(:create_playoff_tournament_data) do
{ {
name: Faker::Creature::Dog.name, name: Faker::Creature::Dog.name,
description: Faker::Lorem.sentence, description: Faker::Lorem.sentence,
@ -114,7 +114,7 @@ RSpec.describe TournamentsController, type: :controller do
context 'without authentication headers' do context 'without authentication headers' do
it 'renders an unauthorized error response' do it 'renders an unauthorized error response' do
put :create, params: create_data put :create, params: create_playoff_tournament_data
expect(response).to have_http_status(:unauthorized) expect(response).to have_http_status(:unauthorized)
end end
end end
@ -127,32 +127,32 @@ RSpec.describe TournamentsController, type: :controller do
context 'with existing teams' do context 'with existing teams' do
it 'creates a new Tournament' do it 'creates a new Tournament' do
expect do expect do
post :create, params: create_data post :create, params: create_playoff_tournament_data
end.to change(Tournament, :count).by(1) end.to change(Tournament, :count).by(1)
end end
it 'associates the new tournament with the authenticated user' do it 'associates the new tournament with the authenticated user' do
expect do expect do
post :create, params: create_data post :create, params: create_playoff_tournament_data
end.to change(@user.tournaments, :count).by(1) end.to change(@user.tournaments, :count).by(1)
end end
it 'associates the given teams with the created tournament' do it 'associates the given teams with the created tournament' do
post :create, params: create_data post :create, params: create_playoff_tournament_data
body = deserialize_response response body = deserialize_response response
tournament = Tournament.find(body[:id]) tournament = Tournament.find(body[:id])
expect(tournament.teams).to match_array(@teams) expect(tournament.teams).to match_array(@teams)
end end
it 'generates a playoff stage' do it 'generates a playoff stage' do
post :create, params: create_data post :create, params: create_playoff_tournament_data
body = deserialize_response response body = deserialize_response response
tournament = Tournament.find(body[:id]) tournament = Tournament.find(body[:id])
expect(tournament.stages.first).to be_a(Stage) expect(tournament.stages.first).to be_a(Stage)
end end
it 'generates a playoff stage with all given teams' do it 'generates a playoff stage with all given teams' do
post :create, params: create_data post :create, params: create_playoff_tournament_data
body = deserialize_response response body = deserialize_response response
tournament = Tournament.find(body[:id]) tournament = Tournament.find(body[:id])
included_teams = tournament.stages.first.matches.map { |m| m.match_scores.map(&:team) }.flatten.uniq included_teams = tournament.stages.first.matches.map { |m| m.match_scores.map(&:team) }.flatten.uniq
@ -160,7 +160,7 @@ RSpec.describe TournamentsController, type: :controller do
end end
it 'renders a JSON response with the new tournament' do it 'renders a JSON response with the new tournament' do
post :create, params: create_data post :create, params: create_playoff_tournament_data
expect(response).to have_http_status(:created) expect(response).to have_http_status(:created)
expect(response.content_type).to eq('application/json') expect(response.content_type).to eq('application/json')
expect(response.location).to eq(tournament_url(Tournament.last)) expect(response.location).to eq(tournament_url(Tournament.last))
@ -169,7 +169,7 @@ RSpec.describe TournamentsController, type: :controller do
context 'with missing teams' do context 'with missing teams' do
it 'returns an error response' do it 'returns an error response' do
data = create_data data = create_playoff_tournament_data
data[:teams] << { id: Team.last.id + 1 } data[:teams] << { id: Team.last.id + 1 }
post :create, params: data post :create, params: data
expect(response).to have_http_status(:not_found) expect(response).to have_http_status(:not_found)
@ -178,7 +178,7 @@ RSpec.describe TournamentsController, type: :controller do
context 'with team names' do context 'with team names' do
it 'creates teams for given names' do it 'creates teams for given names' do
data = create_data data = create_playoff_tournament_data
data.delete :teams data.delete :teams
data[:teams] = (1..12).collect { { name: Faker::Creature::Dog.name } } data[:teams] = (1..12).collect { { name: Faker::Creature::Dog.name } }
expect do expect do