fix: use constant for default beamer name
This commit is contained in:
parent
eb8c2a7284
commit
c9d487f30c
|
|
@ -5,8 +5,9 @@ require 'securerandom'
|
|||
require_relative '../../../e2e/lib/api_client'
|
||||
require_relative '../../../e2e/lib/action_cable_client'
|
||||
|
||||
DEFAULT_BEAMER_NAME = 'default'
|
||||
|
||||
RSpec.describe 'Tournament follower sync beamer websocket HTTP E2E' do
|
||||
default_beamer_name = 'default'
|
||||
required_env_vars = %w[
|
||||
TURNIERE_E2E_EMAIL
|
||||
TURNIERE_E2E_PASSWORD
|
||||
|
|
@ -42,7 +43,7 @@ RSpec.describe 'Tournament follower sync beamer websocket HTTP E2E' do
|
|||
cable_client.subscribe_beamer!(tournament_id: follower.fetch(:id), beamer_name: follower_default_beamer.fetch(:name))
|
||||
cable_client.wait_for_beamer_payload!
|
||||
|
||||
source_default_beamer = fetch_beamer(base_url: source_base_url, tournament_id: source.fetch(:id), beamer_name: default_beamer_name)
|
||||
source_default_beamer = fetch_beamer(base_url: source_base_url, tournament_id: source.fetch(:id), beamer_name: DEFAULT_BEAMER_NAME)
|
||||
update = source_client.patch("/tournaments/#{source.fetch(:id)}/beamers/#{source_default_beamer.fetch(:id)}", body: {
|
||||
display_state: 'groups'
|
||||
})
|
||||
|
|
@ -53,7 +54,7 @@ RSpec.describe 'Tournament follower sync beamer websocket HTTP E2E' do
|
|||
event_type: 'beamer.updated',
|
||||
display_state: 'groups'
|
||||
)
|
||||
expect(follower_payload.dig('beamer', 'name')).to eq(default_beamer_name)
|
||||
expect(follower_payload.dig('beamer', 'name')).to eq(DEFAULT_BEAMER_NAME)
|
||||
ensure
|
||||
cable_client&.close
|
||||
end
|
||||
|
|
@ -108,8 +109,8 @@ RSpec.describe 'Tournament follower sync beamer websocket HTTP E2E' do
|
|||
def wait_for_default_beamer!(tournament_id:, timeout: 20)
|
||||
deadline = Time.now + timeout
|
||||
loop do
|
||||
beamer = fetch_beamer(base_url: follower_base_url, tournament_id:, beamer_name: default_beamer_name)
|
||||
return beamer if beamer.fetch(:name) == default_beamer_name
|
||||
beamer = fetch_beamer(base_url: follower_base_url, tournament_id:, beamer_name: DEFAULT_BEAMER_NAME)
|
||||
return beamer if beamer.fetch(:name) == DEFAULT_BEAMER_NAME
|
||||
|
||||
raise "follower default beamer not present within #{timeout}s" if Time.now >= deadline
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue