From cbf7917e1562f4300492923bbb6ddf7d64365f01 Mon Sep 17 00:00:00 2001
From: Malaber <32635600+Malaber@users.noreply.github.com>
Date: Tue, 4 Jun 2019 19:03:13 +0200
Subject: [PATCH] Test returning unprocessable entity response

We now test sending a senseless state and also what happens when the
match.update method fails for some reason.
---
 spec/controllers/matches_controller_spec.rb | 268 +++++++++++---------
 1 file changed, 149 insertions(+), 119 deletions(-)

diff --git a/spec/controllers/matches_controller_spec.rb b/spec/controllers/matches_controller_spec.rb
index 57b920e..f0a4fa4 100644
--- a/spec/controllers/matches_controller_spec.rb
+++ b/spec/controllers/matches_controller_spec.rb
@@ -27,134 +27,164 @@ RSpec.describe MatchesController, type: :controller do
   end
 
   describe 'POST #update' do
-    let(:valid_update) do
-      {
-        state: 'in_progress'
-      }
-    end
-
-    let(:invalid_update) do
-      {
-        state: 'finished'
-      }
-    end
-
-    context 'as owner' do
-      before(:each) do
-        apply_authentication_headers_for @match.owner
+    context 'on a running playoff match' do
+      let(:valid_update) do
+        {
+          state: 'in_progress'
+        }
       end
 
-      context 'with valid params' do
-        it 'updates the match' do
-          put :update, params: { id: @match.to_param }.merge(valid_update)
-          @match.reload
-          expect(response).to be_successful
-          expect(@match.state).to eq(valid_update[:state])
-        end
-
-        it 'renders a response with the updated match' do
-          put :update, params: { id: @match.to_param }.merge(valid_update)
-          expect(response).to be_successful
-          body = deserialize_response response
-          expect(body[:state]).to eq(valid_update[:state])
-        end
-
-        context 'on a running playoff match' do
-          let(:finished) do
-            {
-              state: 'finished'
-            }
-          end
-
-          before(:each) do
-            apply_authentication_headers_for @running_playoff_match.owner
-          end
-
-          context 'on a decided match' do
-            before do
-              @running_playoff_match.match_scores.each_with_index do |ms, i|
-                ms.points = i
-                ms.save!
-              end
-              put :update, params: { id: @running_playoff_match.to_param }.merge(finished)
-              @running_playoff_match.reload
-            end
-
-            it 'updates the matches status' do
-              expect(response).to be_successful
-              expect(@running_playoff_match.state).to eq(finished[:state])
-            end
-
-            describe 'updates the match below' do
-              before do
-                @match_below = @tournament.stages.find_by(level: @amount_of_stages - 1).matches
-                                          .find_by(position: @running_playoff_match.position / 2).reload
-              end
-
-              it 'with the right teams' do
-                expect(@running_playoff_match.winner).to be_a(Team)
-                expect(@match_below.teams).to include(@running_playoff_match.winner)
-              end
-
-              it 'with the right status' do
-                expect(@match_below.state).to eq('not_ready')
-              end
-            end
-          end
-
-          context 'on a undecided match' do
-            before do
-              @running_playoff_match.match_scores.each do |ms|
-                ms.points = 42
-                ms.save!
-              end
-              put :update, params: { id: @running_playoff_match.to_param }.merge(finished)
-              @running_playoff_match.reload
-            end
-
-            it 'returns unprocessable entity' do
-              expect(response).to have_http_status(:unprocessable_entity)
-            end
-
-            it 'doesn\'t change the matches status' do
-              expect(@running_playoff_match.state).to eq('in_progress')
-            end
-
-            describe 'doesn\'t update the match below' do
-              before do
-                @match_below = @tournament.stages.find_by(level: @amount_of_stages - 1).matches
-                                          .find_by(position: @running_playoff_match.position / 2).reload
-              end
-
-              it 'teams' do
-                expect(@match_below.teams.empty?).to be(true)
-              end
-
-              it 'status' do
-                expect(@match_below.state).to eq('not_ready')
-              end
-            end
-          end
-        end
+      let(:invalid_update) do
+        {
+          state: 'finished'
+        }
       end
 
-      context 'with invalid params' do
-        it 'renders an unprocessable entity response' do
-          put :update, params: { id: @match.to_param }.merge(invalid_update)
-          expect(response).to have_http_status(:unprocessable_entity)
-        end
+      let(:senseless_update) do
+        {
+          state: 'not_ready'
+        }
       end
-    end
 
-    context 'as another user' do
-      context 'with valid params' do
+      context 'as owner' do
         before(:each) do
-          apply_authentication_headers_for create(:user)
+          apply_authentication_headers_for @match.owner
         end
 
-        it 'renders a forbidden error response' do
-          put :update, params: { id: @match.to_param }.merge(valid_update)
-          expect(response).to have_http_status(:forbidden)
+        context 'with valid params' do
+          it 'updates the match' do
+            put :update, params: { id: @match.to_param }.merge(valid_update)
+            @match.reload
+            expect(response).to be_successful
+            expect(@match.state).to eq(valid_update[:state])
+          end
+
+          it 'renders a response with the updated match' do
+            put :update, params: { id: @match.to_param }.merge(valid_update)
+            expect(response).to be_successful
+            body = deserialize_response response
+            expect(body[:state]).to eq(valid_update[:state])
+          end
+
+          context 'on a running playoff match' do
+            let(:finished) do
+              {
+                state: 'finished'
+              }
+            end
+
+            before(:each) do
+              apply_authentication_headers_for @running_playoff_match.owner
+            end
+
+            context 'match update succeeds' do
+              context 'on a decided match' do
+                before do
+                  @running_playoff_match.match_scores.each_with_index do |ms, i|
+                    ms.points = i
+                    ms.save!
+                  end
+                  put :update, params: { id: @running_playoff_match.to_param }.merge(finished)
+                  @running_playoff_match.reload
+                end
+
+                it 'updates the matches status' do
+                  expect(response).to be_successful
+                  expect(@running_playoff_match.state).to eq(finished[:state])
+                end
+
+                describe 'updates the match below' do
+                  before do
+                    @match_below = @tournament.stages.find_by(level: @amount_of_stages - 1).matches
+                                              .find_by(position: @running_playoff_match.position / 2).reload
+                  end
+
+                  it 'with the right teams' do
+                    expect(@running_playoff_match.winner).to be_a(Team)
+                    expect(@match_below.teams).to include(@running_playoff_match.winner)
+                  end
+
+                  it 'with the right status' do
+                    expect(@match_below.state).to eq('not_ready')
+                  end
+                end
+              end
+
+              context 'on a undecided match' do
+                before do
+                  @running_playoff_match.match_scores.each do |ms|
+                    ms.points = 42
+                    ms.save!
+                  end
+                  put :update, params: { id: @running_playoff_match.to_param }.merge(finished)
+                  @running_playoff_match.reload
+                end
+
+                it 'returns unprocessable entity' do
+                  expect(response).to have_http_status(:unprocessable_entity)
+                end
+
+                it 'doesn\'t change the matches status' do
+                  expect(@running_playoff_match.state).to eq('in_progress')
+                end
+
+                describe 'doesn\'t update the match below' do
+                  before do
+                    @match_below = @tournament.stages.find_by(level: @amount_of_stages - 1).matches
+                                              .find_by(position: @running_playoff_match.position / 2).reload
+                  end
+
+                  it 'teams' do
+                    expect(@match_below.teams.empty?).to be(true)
+                  end
+
+                  it 'status' do
+                    expect(@match_below.state).to eq('not_ready')
+                  end
+                end
+              end
+            end
+
+            context 'match update fails' do
+              before do
+                allow_any_instance_of(Match)
+                  .to receive(:update)
+                  .and_return(false)
+              end
+
+              it 'returns unprocessable entity' do
+                put :update, params: { id: @running_playoff_match.to_param }.merge(finished)
+                expect(response).to have_http_status(:unprocessable_entity)
+              end
+            end
+          end
+        end
+
+        context 'with invalid params' do
+          it 'renders an unprocessable entity response' do
+            put :update, params: { id: @match.to_param }.merge(invalid_update)
+            expect(response).to have_http_status(:unprocessable_entity)
+          end
+        end
+
+        context 'with senseless params' do
+          it 'renders an unprocessable entity response' do
+            put :update, params: { id: @match.to_param }.merge(senseless_update)
+            expect(response).to have_http_status(:unprocessable_entity)
+          end
+        end
+      end
+
+      context 'as another user' do
+        context 'with valid params' do
+          before(:each) do
+            apply_authentication_headers_for create(:user)
+          end
+
+          it 'renders a forbidden error response' do
+            put :update, params: { id: @match.to_param }.merge(valid_update)
+            expect(response).to have_http_status(:forbidden)
+          end
         end
       end
     end