Remove unnecessary :group_stage_only tournament

This commit is contained in:
Daniel Schädler 2019-05-30 00:05:55 +02:00
parent 5925f23720
commit f97c8e501c
4 changed files with 11 additions and 14 deletions

View File

@ -13,7 +13,7 @@ RSpec.describe StatisticsController, type: :controller do
context 'tournament with a group stage' do
before do
@tournament = create(:group_stage_only_tournament)
@tournament = create(:group_stage_tournament, stage_count: 0)
@group_stage = @tournament.stages.find_by(level: -1)
@most_dominant_score = create(:group_score,
team: @tournament.teams.first,

View File

@ -12,15 +12,6 @@ FactoryBot.define do
tournament.teams = create_list(:team, evaluator.teams_count, tournament: tournament)
end
factory :group_stage_only_tournament do
transient do
group_count { 2 }
end
after(:create) do |tournament, evaluator|
tournament.stages << create(:group_stage, group_count: evaluator.group_count)
end
end
factory :stage_tournament do
transient do
stage_count { 1 }
@ -44,8 +35,14 @@ FactoryBot.define do
end
factory :group_stage_tournament do
after(:create) do |tournament, _evaluator|
tournament.stages << create(:group_stage)
transient do
group_count { 2 }
match_factory { :group_match }
end
after(:create) do |tournament, evaluator|
tournament.stages << create(:group_stage,
match_factory: evaluator.match_factory,
group_count: evaluator.group_count)
end
end
end

View File

@ -11,7 +11,7 @@ RSpec.describe AddGroupStageToTournament do
before do
@empty_tournament = create(:stageless_tournament)
@group_stage_tournament = create(:group_stage_only_tournament, group_count: 0)
@group_stage_tournament = create(:group_stage_tournament, stage_count: 0, group_count: 0)
@group_stage = create(:group_stage)
@groups = Hash[1 => create_list(:team, 4), 2 => create_list(:team, 4)].values
end

View File

@ -14,7 +14,7 @@ RSpec.describe AddPlayoffsToTournament do
end
before do
@group_stage_tournament = create(:group_stage_only_tournament, group_count: 0)
@group_stage_tournament = create(:group_stage_tournament, stage_count: 0, group_count: 0)
@playoff_stage_tournament = create(:stageless_tournament)
@full_tournament = create(:dummy_stage_tournament)
@stages = create_list(:stage, 3)