From fdac71a9f158e1c94b0e74a31766cf9d2e84d0ef Mon Sep 17 00:00:00 2001 From: Malaber <32635600+Malaber@users.noreply.github.com> Date: Sun, 28 Apr 2019 17:37:44 +0200 Subject: [PATCH] Unnecessary variable assignment --- app/services/group_stage_service.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/services/group_stage_service.rb b/app/services/group_stage_service.rb index 2e93f76..0af32b3 100644 --- a/app/services/group_stage_service.rb +++ b/app/services/group_stage_service.rb @@ -6,9 +6,8 @@ class GroupStageService average_group_size = (groups.flatten.length.to_f / groups.length.to_f) if (average_group_size % 1).zero? - groups = groups.map { |group| get_group_object_from(group) } - group_stage = Stage.new level: -1, groups: groups - group_stage + groups = groups.map(&method(:get_group_object_from)) + Stage.new level: -1, groups: groups else false end @@ -16,8 +15,7 @@ class GroupStageService def self.get_group_object_from(team_array) matches = generate_all_matches_between team_array - group = Group.new matches: matches - group + Group.new matches: matches end def self.generate_all_matches_between(teams)