Commit Graph

145 Commits

Author SHA1 Message Date
Daniel Schädler 0e52663d46 Fix two typos 2019-06-10 18:49:07 +02:00
Daniel Schädler 0c64839319 Test returning unprocessable entity when error occurs in match population 2019-06-10 18:49:07 +02:00
Daniel Schädler 0d85c057b6 Test unprocessable entity response on a match that is not ready
Unprocessable entity is returned when you try to start a match that is
not ready yet.
2019-06-10 18:49:07 +02:00
Daniel Schädler cbf7917e15 Test returning unprocessable entity response
We now test sending a senseless state and also what happens when the
match.update method fails for some reason.
2019-06-10 18:49:07 +02:00
Daniel Schädler f7a46cf21e Split test methods for failed stopping of matches 2019-06-10 18:49:07 +02:00
Daniel Schädler 0afe6badcc Prevent matches from being stopped without a winner in playoffs 2019-06-10 18:49:07 +02:00
Daniel Schädler 03355d4e7e Correct state of empty_prepared_playoff_match factory 2019-06-10 18:49:07 +02:00
Daniel Schädler b8ce4d66c8 Add field to tournament containing playoff_teams_amount
This field represents how many teams advance into playoff stage after
the group stage has ended.
2019-06-10 18:49:07 +02:00
Daniel Schädler c9c47fa0e5 Test returning unprocessable entity when match_score update fails 2019-06-10 18:49:07 +02:00
Daniel Schädler 41f5295a50 Test update_group_scores method 2019-06-10 18:49:07 +02:00
Daniel Schädler 6d85c1128e Rename groups to prepared_groups
This is done because prepared_groups only represents hashes of groups
that still need to be generated rather then actual group objects.
2019-06-10 18:49:07 +02:00
Daniel Schädler a1515fc4c7 Remove unused Variable stage 2019-06-10 18:49:07 +02:00
Daniel Schädler 40cfa479f0 Move scope of tournament creation in match_score controller test
This fixes the problem we had with the update of the match score
returning :forbidden because the @owner variable was not set properly.

Also names of the tests should now be easier to read.
2019-06-10 18:49:07 +02:00
Daniel Schädler b89e2c58d4 Dry out code with shared_examples 2019-06-10 18:49:07 +02:00
Daniel Schädler 9e66bfa1d7 Overwrite owner of tournament manually 2019-06-10 18:49:07 +02:00
Daniel Schädler e567d12ca2 Test if match_score point change triggers group score calculation 2019-06-10 18:49:07 +02:00
Daniel Schädler 4a0e9a78ec Remove unnecessary :group_stage_only tournament 2019-06-10 18:49:07 +02:00
Daniel Schädler 1b0812bce6 Make Match Factory configurable for group_stage and group factory 2019-06-10 18:49:07 +02:00
Daniel Schädler 474a52a0a3 Add group_scores to groups factory, one for every team 2019-06-10 18:49:07 +02:00
Daniel Schädler 037c9ebcf1 Add GroupScore objects for every team to the group stage 2019-06-10 18:49:07 +02:00
Daniel Schädler 3c98fd0545 Update group_scores on match_score change if match is a group match 2019-06-10 18:49:07 +02:00
Daniel Schädler 084c9bb1fc Add method to check if match_score is part of a group match 2019-06-10 18:49:07 +02:00
Daniel Schädler 2cabd1ea7d Correctly handle matches that are not started yet 2019-06-10 18:49:07 +02:00
Daniel Schädler a8744c6987 Implement Methods returning points of teams per match
These methods return group_points scored_points and received_points
respectively when given a team that is present in the match
They return 0 when given a team that isn't contesting in that match
2019-06-10 18:49:07 +02:00
Daniel Schädler 990361a25b Fix comparison that got lost in refactoring 2019-05-27 13:25:14 +02:00
Daniel Schädler a710addde7 Create :stage_tournaments with realistic match positions 2019-05-26 22:03:22 +02:00
Daniel Schädler 537cccfa9e Force save match_scores 2019-05-26 20:15:59 +02:00
Daniel Schädler 6f44823bc6 Change match state of match below 2019-05-26 20:15:59 +02:00
Daniel Schädler 8dd1f0b07c Rearrange Test Code 2019-05-26 20:15:59 +02:00
Daniel Schädler 9f92ca7e5b Move stopping of matches test 2019-05-26 20:15:59 +02:00
Daniel Schädler d61b3b2b63 Fix factory name for stageless tournament 2019-05-26 20:15:59 +02:00
Daniel Schädler 21c79665e1 Check if .winner returns a Team
This is done to prevent Test from succeeding if both
.winner and .teams return nil
2019-05-26 20:15:59 +02:00
Daniel Schädler 74b345dce4 Fix factory name for stage tournament 2019-05-26 20:15:59 +02:00
Daniel Schädler 5457d50277 Simplify code finding the tournament
Co-Authored-By: Thor77 <thor77@thor77.org>
2019-05-26 20:15:59 +02:00
Daniel Schädler 0337b6fad8 Save match_scores after editing them in tests 2019-05-26 20:15:59 +02:00
Daniel Schädler d0d38a7972 Test populate_match_below Interactor 2019-05-26 20:15:58 +02:00
Daniel Schädler e0ef39cc4b Test populate_match_below method 2019-05-26 20:15:58 +02:00
Daniel Schädler d2f5d3594e Test performance optimization
In general this generates less unnecessary faker data
2019-05-26 20:15:16 +02:00
Daniel Schädler bc055843d9 Test stopping of Matches 2019-05-26 20:14:13 +02:00
Daniel Schädler 2f77d2d25b Add winner method to match 2019-05-26 20:14:13 +02:00
Daniel Schädler 280b0c1dec Change status of Match to only represent being finished
The winner will be a attribute of the Match instead of something
that is written in its status.
2019-05-26 20:14:13 +02:00
Daniel Schädler 8388af20f0 Generalize tournament save interactor
It now is responsible for saving all ApplicationRecord objects to the
database. This will reduce code duplication one we have other objects
that need to be saved. (As we will soon need to save individual matches)
2019-05-26 20:14:13 +02:00
Daniel Schädler 51056d340c Save the whole stage instead of the single matches 2019-05-22 09:25:07 +02:00
Daniel Schädler b36e3c4251 Delegate owner of team to tournament again 2019-05-22 09:25:07 +02:00
Daniel Schädler 27709f0136 This change will basically solve climate change as it saves all
the computing power in the whole world.
2019-05-22 09:25:07 +02:00
Thor77 b5377db1f3 Reformat indention 2019-05-22 09:25:07 +02:00
Daniel Schädler d548eee245 Change .map to .each 2019-05-22 09:25:07 +02:00
Daniel Schädler dcb19461be Add group_stage_only_tournament factory 2019-05-22 09:25:07 +02:00
Daniel Schädler 03d7369a1c Remove link between team.owner and tournament 2019-05-22 09:25:07 +02:00
Daniel Schädler f73820f2f2 Reduce standart amount of teams within a tournament to 8 2019-05-22 09:25:07 +02:00