Daniel Schädler
9f3fb532a5
Move sonar-scanner to bottom of travis scripts
...
This is necessary to correctly submit coverage result to sonarqube
2019-05-26 20:24:47 +02:00
Daniel Schädler
537cccfa9e
Force save match_scores
2019-05-26 20:15:59 +02:00
Daniel Schädler
6f44823bc6
Change match state of match below
2019-05-26 20:15:59 +02:00
Daniel Schädler
8dd1f0b07c
Rearrange Test Code
2019-05-26 20:15:59 +02:00
Daniel Schädler
8bdcd51e66
Move all methods in playoff_stage_service into self block
2019-05-26 20:15:59 +02:00
Daniel Schädler
9f92ca7e5b
Move stopping of matches test
2019-05-26 20:15:59 +02:00
Daniel Schädler
d61b3b2b63
Fix factory name for stageless tournament
2019-05-26 20:15:59 +02:00
Daniel Schädler
21c79665e1
Check if .winner returns a Team
...
This is done to prevent Test from succeeding if both
.winner and .teams return nil
2019-05-26 20:15:59 +02:00
Daniel Schädler
74b345dce4
Fix factory name for stage tournament
2019-05-26 20:15:59 +02:00
Daniel Schädler
5457d50277
Simplify code finding the tournament
...
Co-Authored-By: Thor77 <thor77@thor77.org>
2019-05-26 20:15:59 +02:00
Daniel Schädler
0337b6fad8
Save match_scores after editing them in tests
2019-05-26 20:15:59 +02:00
Daniel Schädler
d0d38a7972
Test populate_match_below Interactor
2019-05-26 20:15:58 +02:00
Daniel Schädler
645f3d0800
Return changed objects in populate_match_below
2019-05-26 20:15:58 +02:00
Daniel Schädler
95bed3959f
Actually make singleton_methods private
...
(Rubocop told me so and I trust the police)
2019-05-26 20:15:58 +02:00
Daniel Schädler
e0ef39cc4b
Test populate_match_below method
2019-05-26 20:15:58 +02:00
Daniel Schädler
cda7d168f5
Save match_scores explicitly after changing them
2019-05-26 20:15:58 +02:00
Daniel Schädler
93cea002f9
Change the way, existing match_scores are handled
2019-05-26 20:15:58 +02:00
Daniel Schädler
2b39bb1521
Move populating the match below to when the state is changed
2019-05-26 20:15:58 +02:00
Daniel Schädler
7a9da4e22d
Rearrange methods in playoff_stage_service
2019-05-26 20:15:58 +02:00
Daniel Schädler
27d6269f94
Rearrange new methods into one to split it later on
2019-05-26 20:15:58 +02:00
Daniel Schädler
4e907b1fc8
Improve Formatting in playoff_stage_service (I guess)
...
... Rubocop wanted it that way
2019-05-26 20:15:16 +02:00
Daniel Schädler
e4c868c150
Fix second match winner advancing, even if match is not finished
2019-05-26 20:15:16 +02:00
Daniel Schädler
12daf53599
Check for errors while populating the match below
2019-05-26 20:15:16 +02:00
Daniel Schädler
fc69c6e6e6
Implement PopulateMatchBelow Interactor & Organizer
2019-05-26 20:15:16 +02:00
Daniel Schädler
d2f5d3594e
Test performance optimization
...
In general this generates less unnecessary faker data
2019-05-26 20:15:16 +02:00
Daniel Schädler
c9b07f7033
Implement populate_match_below method
2019-05-26 20:14:13 +02:00
Daniel Schädler
bc055843d9
Test stopping of Matches
2019-05-26 20:14:13 +02:00
Daniel Schädler
2c9e06946d
Call populate_match_below when a match is finished
2019-05-26 20:14:13 +02:00
Daniel Schädler
2f77d2d25b
Add winner method to match
2019-05-26 20:14:13 +02:00
Daniel Schädler
280b0c1dec
Change status of Match to only represent being finished
...
The winner will be a attribute of the Match instead of something
that is written in its status.
2019-05-26 20:14:13 +02:00
Daniel Schädler
1a2caaedef
Remove unused evaluate status method
2019-05-26 20:14:13 +02:00
Daniel Schädler
9cfead9723
Make save_application_record_object work with arrays
2019-05-26 20:14:13 +02:00
Daniel Schädler
8388af20f0
Generalize tournament save interactor
...
It now is responsible for saving all ApplicationRecord objects to the
database. This will reduce code duplication one we have other objects
that need to be saved. (As we will soon need to save individual matches)
2019-05-26 20:14:13 +02:00
Daniel Schädler
3ed8165501
Merge pull request #45 from turniere/ticket/TURNIERE-218
...
Add sonarqube & Code Climate Code analysis
2019-05-26 19:28:24 +02:00
Daniel Schädler
a89291a396
Remove multiple top level headings
2019-05-26 17:43:57 +02:00
Daniel Schädler
08b2f8751b
Add missing code-language flag
2019-05-26 17:43:25 +02:00
Daniel Schädler
4a7e207e9b
Fix missing title in unused E-Mail Template
2019-05-26 17:41:11 +02:00
Daniel Schädler
58bd3f2f86
Add CodeClimate Badge
2019-05-26 13:03:40 +02:00
Daniel Schädler
b84481d69b
Add sonarqube Code analysis
2019-05-26 12:53:27 +02:00
Thor77
543234cf09
Merge pull request #44 from turniere/ticket/TURNIERE-218
...
Add Codacy Badge
2019-05-23 15:06:08 +02:00
Daniel Schädler
de5b87a94f
Add Codacy Badge
...
This badge saves lives as it provides very excellent metrics describing
the code quality.
2019-05-23 14:48:39 +02:00
Daniel Schädler
0c9c0bd526
Merge pull request #37 from turniere/ticket/TURNIERE-196
...
Factory Overhaul
2019-05-22 10:03:32 +02:00
Daniel Schädler
51056d340c
Save the whole stage instead of the single matches
2019-05-22 09:25:07 +02:00
Daniel Schädler
b36e3c4251
Delegate owner of team to tournament again
2019-05-22 09:25:07 +02:00
Daniel Schädler
27709f0136
This change will basically solve climate change as it saves all
...
the computing power in the whole world.
2019-05-22 09:25:07 +02:00
Thor77
b5377db1f3
Reformat indention
2019-05-22 09:25:07 +02:00
Daniel Schädler
d548eee245
Change .map to .each
2019-05-22 09:25:07 +02:00
Daniel Schädler
dcb19461be
Add group_stage_only_tournament factory
2019-05-22 09:25:07 +02:00
Daniel Schädler
03d7369a1c
Remove link between team.owner and tournament
2019-05-22 09:25:07 +02:00
Daniel Schädler
f73820f2f2
Reduce standart amount of teams within a tournament to 8
2019-05-22 09:25:07 +02:00