From 2cd4f77f221df9ff8b3f8b665959434666985b71 Mon Sep 17 00:00:00 2001
From: JP1998 <littlebigjonny06@gmail.com>
Date: Thu, 11 Apr 2019 14:52:49 +0200
Subject: [PATCH 01/11] Make the commands in the README uniform

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 18d57da..fde2c49 100644
--- a/README.md
+++ b/README.md
@@ -15,7 +15,7 @@ $ git clone https://github.com/turniere/turniere-frontend.git
 Afterwards you'll have to install the used libraries using following command:
 
 ```
-yarn install
+$ yarn install
 ```
 
 Afterwards you may simply run the developer version of the project:

From 47b4c4602b6838d9f461eba5b297c04849d05e5b Mon Sep 17 00:00:00 2001
From: Felix Hamme <gitlab@fj.hamme.net>
Date: Tue, 16 Apr 2019 14:13:01 +0200
Subject: [PATCH 02/11] Replace disgusting code with beautiful code

---
 js/components/Login.js | 7 +------
 pages/register.js      | 8 +-------
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/js/components/Login.js b/js/components/Login.js
index 174677b..6b8db0e 100644
--- a/js/components/Login.js
+++ b/js/components/Login.js
@@ -31,14 +31,9 @@ class LoginErrorList extends React.Component {
         const { error, errorMessages } = this.props;
         if(error) {
             return (
-                <ul>
+                <ul className='text-danger mt-3'>
                     { errorMessages.map((message, index) => 
                         <li key={index}>
-                            <style jsx>{`
-                                li {
-                                    color:red;
-                                }
-                            `}</style>
                             {message}
                         </li>
 
diff --git a/pages/register.js b/pages/register.js
index d655a5e..3395c3d 100644
--- a/pages/register.js
+++ b/pages/register.js
@@ -69,17 +69,11 @@ class RegisterErrorList extends React.Component {
         const { error, errorMessages } = this.props;
         if(error) {
             return (
-                <ul>
+                <ul className='text-danger mt-3'>
                     { errorMessages.map((message, index) => 
                         <li key={index}>
-                            <style jsx>{`
-                                li {
-                                    color:red;
-                                }
-                            `}</style>
                             {message}
                         </li>
-
                     ) }
                 </ul>
             );

From 303f774989df4e6979a1ada5c124f732390bfdf8 Mon Sep 17 00:00:00 2001
From: Felix Hamme <gitlab@fj.hamme.net>
Date: Tue, 16 Apr 2019 14:17:03 +0200
Subject: [PATCH 03/11] Use strong typed comparison expressions

---
 pages/tournament.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/pages/tournament.js b/pages/tournament.js
index da0c919..52581f8 100644
--- a/pages/tournament.js
+++ b/pages/tournament.js
@@ -56,7 +56,7 @@ class PrivateTournamentPage extends React.Component {
                 </Container>
                 <div className='stages pt-5'>
                     {playoffStages.map(stage =>
-                        <Stage isSignedIn={isSignedIn} isOwner={username == ownerUsername} level={getLevelName(stage.level)} matches={stage.matches} key={stage.level}/>)}
+                        <Stage isSignedIn={isSignedIn} isOwner={username === ownerUsername} level={getLevelName(stage.level)} matches={stage.matches} key={stage.level}/>)}
                 </div>
             </div>
         );
@@ -368,12 +368,12 @@ function convertMatch(apiMatch) {
         state: apiMatch.state
     };
 
-    if(apiMatch.match_scores.length == 2) {
+    if(apiMatch.match_scores.length === 2) {
         result.team1 = apiMatch.match_scores[0].team.name;
         result.scoreTeam1 = apiMatch.match_scores[0].points;
         result.team2 = apiMatch.match_scores[1].team.name;
         result.scoreTeam2 = apiMatch.match_scores[1].points;
-    } else if(apiMatch.match_scores.length == 1) {
+    } else if(apiMatch.match_scores.length === 1) {
         result.team1 = apiMatch.match_scores[0].team.name;
         result.scoreTeam1 = apiMatch.match_scores[0].points;
         result.team2 = 'TBD';
@@ -424,7 +424,7 @@ class Main extends React.Component {
 
         const { status, tournament } = this.state;
 
-        if (status == 200) {
+        if (status === 200) {
             return (
                 <div>
                     <Head>

From b0b6fb84e0cb3fd07b84b95b35195652de3bea2a Mon Sep 17 00:00:00 2001
From: Felix Hamme <gitlab@fj.hamme.net>
Date: Tue, 16 Apr 2019 14:25:42 +0200
Subject: [PATCH 04/11] Use smaller scope for variables

---
 pages/create.js          | 4 ++--
 pages/tournament-edit.js | 2 +-
 pages/tournament.js      | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/pages/create.js b/pages/create.js
index 2565c7c..e5d0aae 100644
--- a/pages/create.js
+++ b/pages/create.js
@@ -181,9 +181,9 @@ class CreateTournamentForm extends React.Component {
     }
 
     createTeamArray(teamnames) {
-        var result = [];
+        let result = [];
 
-        for(var i = 0; i < teamnames.length; i++) {
+        for(let i = 0; i < teamnames.length; i++) {
             result[i] = { 'name': teamnames[i] };
         }
 
diff --git a/pages/tournament-edit.js b/pages/tournament-edit.js
index e0b0fcd..afb43df 100644
--- a/pages/tournament-edit.js
+++ b/pages/tournament-edit.js
@@ -279,7 +279,7 @@ class EditTeamNamesForm extends React.Component {
     }
 
     handleNameInput(index, input) {
-        var team = this.state.teams.slice();
+        let team = this.state.teams.slice();
 
         team[index].name = input.target.value;
 
diff --git a/pages/tournament.js b/pages/tournament.js
index 52581f8..e0d42c2 100644
--- a/pages/tournament.js
+++ b/pages/tournament.js
@@ -363,7 +363,7 @@ function convertGroup(apiGroup) {
 }
 
 function convertMatch(apiMatch) {
-    var result = {
+    let result = {
         id: apiMatch.id,
         state: apiMatch.state
     };

From f97fc23a4c5f12ded85fd4601cd4e5d67cf9611f Mon Sep 17 00:00:00 2001
From: Jonny <littlebigjonny06@gmail.com>
Date: Wed, 17 Apr 2019 16:30:00 +0200
Subject: [PATCH 05/11] Format the error messages for registering

---
 pages/register.js            | 10 +++-------
 static/css/errormessages.css | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+), 7 deletions(-)
 create mode 100644 static/css/errormessages.css

diff --git a/pages/register.js b/pages/register.js
index 3395c3d..31fad19 100644
--- a/pages/register.js
+++ b/pages/register.js
@@ -21,9 +21,9 @@ import {
 }  from '../js/api';
 
 import '../static/everypage.css';
+import '../static/css/errormessages.css';
 
 export default class RegisterPage extends React.Component {
-
     render() {
         return (
             <div className="main generic-fullpage-bg">
@@ -42,7 +42,6 @@ export default class RegisterPage extends React.Component {
 }
 
 class Register extends React.Component {
-
     componentDidMount() {
         clearErrors();
     }
@@ -69,11 +68,9 @@ class RegisterErrorList extends React.Component {
         const { error, errorMessages } = this.props;
         if(error) {
             return (
-                <ul className='text-danger mt-3'>
+                <ul className="mt-3 error-box">
                     { errorMessages.map((message, index) => 
-                        <li key={index}>
-                            {message}
-                        </li>
+                        <li key={index}>{message}</li>
                     ) }
                 </ul>
             );
@@ -93,7 +90,6 @@ const VisibleRegisterErrorList = connect(
 )(RegisterErrorList);
 
 class RegisterForm extends React.Component {
-
     constructor(props) {
         super(props);
 
diff --git a/static/css/errormessages.css b/static/css/errormessages.css
new file mode 100644
index 0000000..d0babb6
--- /dev/null
+++ b/static/css/errormessages.css
@@ -0,0 +1,20 @@
+
+.error-box {
+    border: 2px solid #dc3545;
+    border-radius: 4px;
+
+    padding-right: 16px;
+    padding-left: 16px;
+    padding-top: 8px;
+    padding-bottom: 8px;
+}
+
+.error-box > li {
+    color: #dc3545;
+    margin-right: 36px;
+    display: inline;
+}
+
+.error-box > li:last-child {
+    margin-right: 0px;
+}
\ No newline at end of file

From 0643b4bb0eb9dc824a5bb430a37539f32e1c3ac9 Mon Sep 17 00:00:00 2001
From: Jonny <littlebigjonny06@gmail.com>
Date: Wed, 17 Apr 2019 16:32:49 +0200
Subject: [PATCH 06/11] Format the errors for logging in

---
 js/components/Login.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/js/components/Login.js b/js/components/Login.js
index 6b8db0e..2d2b599 100644
--- a/js/components/Login.js
+++ b/js/components/Login.js
@@ -8,6 +8,8 @@ import {
     clearErrors
 } from '../api';
 
+import '../../static/css/errormessages.css';
+
 export function Login(props) {
     return (
         <Container className="py-5">
@@ -31,7 +33,7 @@ class LoginErrorList extends React.Component {
         const { error, errorMessages } = this.props;
         if(error) {
             return (
-                <ul className='text-danger mt-3'>
+                <ul className='mt-3 error-box'>
                     { errorMessages.map((message, index) => 
                         <li key={index}>
                             {message}

From dfb709d37e246633a882bcc481278bb75cfb31ef Mon Sep 17 00:00:00 2001
From: Jonny <littlebigjonny06@gmail.com>
Date: Thu, 18 Apr 2019 10:19:37 +0200
Subject: [PATCH 07/11] Remove the wrapping data object from the response of
 login

---
 js/api.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/api.js b/js/api.js
index a065064..7877298 100644
--- a/js/api.js
+++ b/js/api.js
@@ -188,7 +188,7 @@ const reducer_userinfo = (state = defaultstate_userinfo, action) => {
             __store.dispatch({
                 type : actiontypes_userinfo.LOGIN_RESULT_SUCCESS,
                 parameters : {
-                    username : resp.data.data.username,
+                    username : resp.data.username,
                 }
             });
             storeOptionalToken(resp);

From 6dce02ae8365cbcb7c49abea7001629443bd0084 Mon Sep 17 00:00:00 2001
From: Felix Hamme <git@fj.hamme.net>
Date: Mon, 22 Apr 2019 16:41:37 +0200
Subject: [PATCH 08/11] Tweak Design

---
 static/css/errormessages.css | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/static/css/errormessages.css b/static/css/errormessages.css
index d0babb6..f7d6b93 100644
--- a/static/css/errormessages.css
+++ b/static/css/errormessages.css
@@ -2,19 +2,11 @@
 .error-box {
     border: 2px solid #dc3545;
     border-radius: 4px;
-
-    padding-right: 16px;
-    padding-left: 16px;
-    padding-top: 8px;
-    padding-bottom: 8px;
+    padding: 8px 16px;
 }
 
 .error-box > li {
     color: #dc3545;
     margin-right: 36px;
-    display: inline;
-}
-
-.error-box > li:last-child {
-    margin-right: 0px;
+    list-style-type: none;
 }
\ No newline at end of file

From 45d2b221eb81e51e95df98e1e7a07cc35e1c9fbf Mon Sep 17 00:00:00 2001
From: Felix Hamme <git@fj.hamme.net>
Date: Mon, 22 Apr 2019 16:43:14 +0200
Subject: [PATCH 09/11] Apply css files in the same order everywhere (eliminate
 warning by mini-css-extract-plugin)

---
 pages/register.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pages/register.js b/pages/register.js
index 31fad19..6b05493 100644
--- a/pages/register.js
+++ b/pages/register.js
@@ -20,8 +20,8 @@ import {
     clearErrors
 }  from '../js/api';
 
-import '../static/everypage.css';
 import '../static/css/errormessages.css';
+import '../static/everypage.css';
 
 export default class RegisterPage extends React.Component {
     render() {

From 6af5f9dc72caec6d17d43adc71f8557669e93efe Mon Sep 17 00:00:00 2001
From: Jonny <littlebigjonny06@gmail.com>
Date: Tue, 23 Apr 2019 11:27:02 +0200
Subject: [PATCH 10/11] Add logic for creation of the data for group stages

---
 pages/create.js | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/pages/create.js b/pages/create.js
index 77ed3aa..799252e 100644
--- a/pages/create.js
+++ b/pages/create.js
@@ -217,7 +217,8 @@ class CreateTournamentForm extends React.Component {
             'name': this.state.name,
             'description': this.state.description,
             'public': this.state.public,
-            'teams': this.createTeamArray(this.state.teams)
+            'group_stage': this.state.groupPhaseEnabled,
+            'teams': this.createTeamArray(this.state.groupPhaseEnabled, this.state.groups, this.state.teams)
         }, () => {
             notify.show('Das Turnier wurde erfolgreich erstellt.', 'success', 5000);
         }, () => {
@@ -225,11 +226,22 @@ class CreateTournamentForm extends React.Component {
         });
     }
 
-    createTeamArray(teamnames) {
+    createTeamArray(/* boolean */ groupphase, /* String[][] */ groups, /* String[] */ teams) {
         let result = [];
 
-        for(let i = 0; i < teamnames.length; i++) {
-            result[i] = { 'name': teamnames[i] };
+        if(groupphase) {
+            for(let groupNumber = 0; groupNumber < groups.length; groupNumber++) {
+                for(let groupMember = 0; groupMember < groups[groupNumber].length; groupMember++) {
+                    result[result.length] = {
+                        'name': groups[groupNumber][groupMember],
+                        'group': groupNumber
+                    };
+                }
+            }
+        } else {
+            for(let i = 0; i < teams.length; i++) {
+                result[i] = { 'name': teams[i] };
+            }
         }
 
         return result;

From 2217212a4aad29158a90b431e59a82535512dd5c Mon Sep 17 00:00:00 2001
From: JP1998 <littlebigjonny06@gmail.com>
Date: Tue, 23 Apr 2019 23:52:22 +0200
Subject: [PATCH 11/11] Refactoring the createTeamArray-method

---
 pages/create.js | 51 ++++++++++++++++++++++++++++++++-----------------
 1 file changed, 34 insertions(+), 17 deletions(-)

diff --git a/pages/create.js b/pages/create.js
index 799252e..0eb32b3 100644
--- a/pages/create.js
+++ b/pages/create.js
@@ -218,7 +218,7 @@ class CreateTournamentForm extends React.Component {
             'description': this.state.description,
             'public': this.state.public,
             'group_stage': this.state.groupPhaseEnabled,
-            'teams': this.createTeamArray(this.state.groupPhaseEnabled, this.state.groups, this.state.teams)
+            'teams': createTeamArray(this.state.groupPhaseEnabled, this.state.groups, this.state.teams)
         }, () => {
             notify.show('Das Turnier wurde erfolgreich erstellt.', 'success', 5000);
         }, () => {
@@ -226,24 +226,41 @@ class CreateTournamentForm extends React.Component {
         });
     }
 
-    createTeamArray(/* boolean */ groupphase, /* String[][] */ groups, /* String[] */ teams) {
-        let result = [];
+}
 
-        if(groupphase) {
-            for(let groupNumber = 0; groupNumber < groups.length; groupNumber++) {
-                for(let groupMember = 0; groupMember < groups[groupNumber].length; groupMember++) {
-                    result[result.length] = {
-                        'name': groups[groupNumber][groupMember],
-                        'group': groupNumber
-                    };
-                }
-            }
-        } else {
-            for(let i = 0; i < teams.length; i++) {
-                result[i] = { 'name': teams[i] };
+/**
+ * This method creates an array of team objects that conform to the currently
+ * api specs available at https://apidoc.turnie.re/
+ *
+ * @param {boolean} groupphase Whether a group phase is to be created
+ * @param {string[][]} groups The teams split into the groups that are
+ *     to be used in the group phase of the tournament. Please note that
+ *     according to the api every team can only occur once (not enforced
+ *     by this method) and that every team from {@param teams} will have
+ *     to be in one of the groups (also not enforced by this method, but
+ *     might lead to inconsistencies)
+ * @param {string[]} teams An array containing all names of the teams
+ *     that are to be created for the tournament
+ * @return {Object[]} an array of teams that can be directly sent to the
+ *     backend
+ */
+function createTeamArray(groupphase, groups, teams) {
+    let result = [];
+
+    if(groupphase) {
+        for(let groupNumber = 0; groupNumber < groups.length; groupNumber++) {
+            for(let groupMember = 0; groupMember < groups[groupNumber].length; groupMember++) {
+                result[result.length] = {
+                    'name': groups[groupNumber][groupMember],
+                    'group': groupNumber
+                };
             }
         }
-
-        return result;
+    } else {
+        for(let i = 0; i < teams.length; i++) {
+            result[i] = { 'name': teams[i] };
+        }
     }
+
+    return result;
 }