Test controller params as they're documented

This commit is contained in:
Thor77 2019-04-07 13:40:03 +02:00
parent 9d914774a2
commit 667d6a028c
No known key found for this signature in database
GPG Key ID: 5051E71B46AA669A
3 changed files with 10 additions and 10 deletions

View File

@ -36,13 +36,13 @@ RSpec.describe MatchScoresController, type: :controller do
end
it 'updates the requested score' do
put :update, params: { id: @match_score.to_param, match_score: valid_update }
put :update, params: { id: @match_score.to_param }.merge(valid_update)
@match_score.reload
expect(@match_score.points).to eq(valid_update[:points])
end
it 'renders a response with the updated team' do
put :update, params: { id: @match_score.to_param, match_score: valid_update }
put :update, params: { id: @match_score.to_param }.merge(valid_update)
expect(response).to be_successful
body = deserialize_response response
expect(body[:points]).to eq(valid_update[:points])
@ -55,7 +55,7 @@ RSpec.describe MatchScoresController, type: :controller do
end
it 'renders a forbidden error response' do
put :update, params: { id: @match_score.to_param, match_score: valid_update }
put :update, params: { id: @match_score.to_param }.merge(valid_update)
expect(response).to have_http_status(:forbidden)
end
end

View File

@ -34,14 +34,14 @@ RSpec.describe TeamsController, type: :controller do
end
it 'updates the requested team' do
put :update, params: { id: @team.to_param, team: valid_update }
put :update, params: { id: @team.to_param }.merge(valid_update)
@team.reload
expect(response).to be_successful
expect(@team.name).to eq(valid_update[:name])
end
it 'renders a response with the updated team' do
put :update, params: { id: @team.to_param, team: valid_update }
put :update, params: { id: @team.to_param }.merge(valid_update)
expect(response).to be_successful
body = deserialize_response response
expect(body[:name]).to eq(valid_update[:name])
@ -54,7 +54,7 @@ RSpec.describe TeamsController, type: :controller do
end
it 'renders a forbidden error response' do
put :update, params: { id: @team.to_param, team: valid_update }
put :update, params: { id: @team.to_param }.merge(valid_update)
expect(response).to have_http_status(:forbidden)
end
end

View File

@ -116,7 +116,7 @@ RSpec.describe TournamentsController, type: :controller do
context 'with valid params' do
context 'without authentication headers' do
it 'renders a unauthorized error response' do
put :update, params: { id: @tournament.to_param, tournament: valid_update }
put :update, params: { id: @tournament.to_param }.merge(valid_update)
expect(response).to have_http_status(:unauthorized)
end
end
@ -127,13 +127,13 @@ RSpec.describe TournamentsController, type: :controller do
end
it 'updates the requested tournament' do
put :update, params: { id: @tournament.to_param, tournament: valid_update }
put :update, params: { id: @tournament.to_param }.merge(valid_update)
@tournament.reload
expect(@tournament.name).to eq(valid_update[:name])
end
it 'renders a JSON response with the tournament' do
put :update, params: { id: @tournament.to_param, tournament: valid_update }
put :update, params: { id: @tournament.to_param }.merge(valid_update)
expect(response).to have_http_status(:ok)
expect(response.content_type).to eq('application/json')
end
@ -145,7 +145,7 @@ RSpec.describe TournamentsController, type: :controller do
end
it 'renders a forbidden error response' do
put :update, params: { id: @tournament.to_param, tournament: valid_update }
put :update, params: { id: @tournament.to_param }.merge(valid_update)
expect(response).to have_http_status(:forbidden)
end
end