Daniel Schädler
6b2fc7e33f
fixup to 3cad50776f
2019-06-05 00:17:42 +02:00
Daniel Schädler
8634bddcaf
fixup to 3cad50776f
2019-06-05 00:15:54 +02:00
Daniel Schädler
0c072b7719
One Liners everywhere!
...
Jonas apparently thinks this is better then it was before.. i don't
really care so here we go ¯\_(ツ)_/¯
2019-06-05 00:14:09 +02:00
Daniel Schädler
f9a9ce635c
fixup b94bb9cdcd
2019-06-05 00:07:54 +02:00
Daniel Schädler
47cd94e1ec
Combine two guard clauses into one
2019-06-05 00:06:38 +02:00
Daniel Schädler
aa1bb63038
Move shared example test to bottom of context
...
This will make jonas sleep well at nigh, so it is worth it.
2019-06-04 23:58:29 +02:00
Daniel Schädler
9c029009fb
fixup to test update group scores method 3d8abe449a
...
Co-Authored-By: Thor77 <thor77@thor77.org>
2019-06-04 23:54:19 +02:00
Daniel Schädler
3d8abe449a
Test update_group_scores method
2019-06-04 15:09:21 +02:00
Daniel Schädler
b1af138ed8
Make Hound woof happily
2019-06-04 15:09:21 +02:00
Daniel Schädler
688e2da706
Rename @groups to @prepared_groups
...
This is done because @prepared_groups only represents hashes of groups
that still need to be generated rather then actual group objects.
2019-06-04 15:09:21 +02:00
Daniel Schädler
2bc471082e
Remove unused Variable @stage
2019-06-04 15:09:21 +02:00
Daniel Schädler
b1ff7d2e96
Move scope of tournament creation in match_score controller test
...
This fixes the problem we had with the update of the match score
returning :forbidden because the @owner variable was not set properly.
Also names of the tests should now be easier to read.
2019-06-04 15:09:21 +02:00
Daniel Schädler
71976ba550
Dry out code with shared_examples
2019-06-04 15:09:21 +02:00
Daniel Schädler
f2a18ec08e
Overwrite owner of tournament manually
2019-06-04 15:09:21 +02:00
Daniel Schädler
23d167e04d
Test if match_score point change triggers group score calculation
2019-06-04 15:09:21 +02:00
Daniel Schädler
79b4008082
Remove unnecessary :group_stage_only tournament
2019-06-04 15:09:21 +02:00
Daniel Schädler
8a95f24211
Make Match Factory configurable for group_stage and group factory
2019-06-04 15:09:21 +02:00
Daniel Schädler
133cbffc71
Add group_scores to groups factory, one for every team
2019-06-04 15:09:21 +02:00
Daniel Schädler
5809a062a6
Add GroupScore objects for every team to the group stage
2019-06-04 15:09:21 +02:00
Daniel Schädler
3cad50776f
Update group_scores on match_score change if match is a group match
2019-06-04 15:09:21 +02:00
Daniel Schädler
b94bb9cdcd
Add method to check if match_score is part of a group match
2019-06-04 15:09:21 +02:00
Daniel Schädler
63a5a9832e
Implement update_group_score method
...
This method calculates all the group scores of the group given to it
2019-06-04 15:09:21 +02:00
Daniel Schädler
5406f393d3
Correctly handle matches that are not started yet
2019-06-04 15:09:21 +02:00
Daniel Schädler
9e4d506e66
Fix typo in received_points
2019-06-04 15:09:21 +02:00
Daniel Schädler
6d7cdbc317
Implement Methods returning points of teams per match
...
These methods return group_points scored_points and received_points
respectively when given a team that is present in the match
They return 0 when given a team that isn't contesting in that match
2019-06-04 15:09:21 +02:00
Daniel Schädler
5900328944
Move self methods into self block
2019-06-04 15:09:21 +02:00
Daniel Schädler
b40f5eaff2
Call calculate_group_points on Match_score Update
2019-06-04 15:09:21 +02:00
Thor77
91e646e518
Merge pull request #49 from turniere/ticket/TURNIERE-210
...
Permit username key for account update
2019-06-04 10:26:54 +02:00
Thor77
b07447aaae
Permit username key for account update
2019-06-04 09:55:45 +02:00
Thor77
08eabcd0f9
Merge pull request #47 from turniere/ticket/TURNIERE-225
...
Add winner attribute to match serializer
2019-05-28 23:32:11 +02:00
Thor77
91fe9dba16
Add winner attribute to match serializer
2019-05-28 23:18:55 +02:00
Daniel Schädler
4e0da7f8ab
Merge pull request #46 from turniere/ticket/TURNIERE-223
...
Fix group scores not serialized correctly
2019-05-28 23:08:29 +02:00
Thor77
12005b95fa
Fix group score not serialized correctly
...
when returned from statistics endpoint
2019-05-28 22:24:03 +02:00
Daniel Schädler
e281b1b23f
Merge pull request #38 from turniere/ticket/TURNIERE-190
...
Implement stopping of matches
2019-05-27 14:38:45 +02:00
Daniel Schädler
990361a25b
Fix comparison that got lost in refactoring
2019-05-27 13:25:14 +02:00
Daniel Schädler
a710addde7
Create :stage_tournaments with realistic match positions
2019-05-26 22:03:22 +02:00
Daniel Schädler
9f3fb532a5
Move sonar-scanner to bottom of travis scripts
...
This is necessary to correctly submit coverage result to sonarqube
2019-05-26 20:24:47 +02:00
Daniel Schädler
537cccfa9e
Force save match_scores
2019-05-26 20:15:59 +02:00
Daniel Schädler
6f44823bc6
Change match state of match below
2019-05-26 20:15:59 +02:00
Daniel Schädler
8dd1f0b07c
Rearrange Test Code
2019-05-26 20:15:59 +02:00
Daniel Schädler
8bdcd51e66
Move all methods in playoff_stage_service into self block
2019-05-26 20:15:59 +02:00
Daniel Schädler
9f92ca7e5b
Move stopping of matches test
2019-05-26 20:15:59 +02:00
Daniel Schädler
d61b3b2b63
Fix factory name for stageless tournament
2019-05-26 20:15:59 +02:00
Daniel Schädler
21c79665e1
Check if .winner returns a Team
...
This is done to prevent Test from succeeding if both
.winner and .teams return nil
2019-05-26 20:15:59 +02:00
Daniel Schädler
74b345dce4
Fix factory name for stage tournament
2019-05-26 20:15:59 +02:00
Daniel Schädler
5457d50277
Simplify code finding the tournament
...
Co-Authored-By: Thor77 <thor77@thor77.org>
2019-05-26 20:15:59 +02:00
Daniel Schädler
0337b6fad8
Save match_scores after editing them in tests
2019-05-26 20:15:59 +02:00
Daniel Schädler
d0d38a7972
Test populate_match_below Interactor
2019-05-26 20:15:58 +02:00
Daniel Schädler
645f3d0800
Return changed objects in populate_match_below
2019-05-26 20:15:58 +02:00
Daniel Schädler
95bed3959f
Actually make singleton_methods private
...
(Rubocop told me so and I trust the police)
2019-05-26 20:15:58 +02:00
Daniel Schädler
Thor77